Remove unused using-declarations#20953
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20953
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
The following ciflow label(s) have been added but CI has not been triggered yet because the workflows are awaiting approval:
Once a maintainer approves the workflows (scroll to the bottom of the PR page), the corresponding CI jobs will be triggered automatically. Please ping one of the reviewers if you do not have access to approve and run workflows. |
This PR needs a
|
|
Thanks for doing this @cyyever! It looks like a pybind submodule update snuck into the commit, I assume that was unintentional? |
161a081 to
5fbdd00
Compare
|
@rascani That was unintentional commit, restored it. |
Signed-off-by: cyy <cyyever@outlook.com>
5fbdd00 to
40902e2
Compare
Delete using-declarations whose name is never used in the file (384 across 218 .cpp/.mm files, found by scripted scan). Deletion only — no call sites changed. Using-declarations in headers are left alone since includers may rely on them.
Authored with Claude Code.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani